Repository navigation
fix: start playback after a seek at the position asked for - #493
Merged
Merged
Conversation
The reader lands on the keyframe before the position. The player now decodes from there, drops the video before the position and cuts the audio frame it falls in.
The video decoder drops them as they come out of the codec, so a frame decoded in hardware is not read back and none goes through swscale. While the hardware is on probation they are converted all the same, since only a full picture ends it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A seek landed on the keyframe before the position and played from there, so
seek(1_500_000)started at 1 s. The player now decodes from the keyframe, drops the video before the position and cuts the audio frame it falls in, so the first chunk starts at it.