Repository navigation
fix: end a recording cleanly when its writer thread throws - #491
Merged
Merged
Conversation
An exception leaving MediaRecorder::Run() ended the process. The writer now fails the recording, drops what is queued, reports onError and finishes the file. ExtractExtradata frees its filter and packet by RAII.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception leaving
MediaRecorder::Run(), such asstd::bad_allocfrompending_.push_back()orextradata_.assign(), ended the whole process.Run()catches what the writer loop throws. The recording then fails, drops what is queued, reportsonErroronce (the out-of-memory message is made in advance) and finishes the file, so it ends asPARTIALorFAILED.RecorderTrack::ExtractExtradatafrees its bitstream filter and packet by RAII.AllocationFault.failWriterAllocation()injects the fault on the writer thread, with tests before and after the header.