Repository navigation
fix: report Java exceptions from native callbacks in one piece - #451
Merged
Merged
Conversation
ExceptionDescribe writes "Exception in thread ..." to native stderr and the stack trace to System.err. The prefixes piled up unterminated until a native line ended them (on macOS the Java2D GL warning in VideoViewTests), and setup-java's problem matcher turned that line into an error annotation on every macOS test job. Hand such exceptions to the thread's uncaught exception handler instead, as other callbacks already do, and stop describing in ExceptionCheck, whose exception travels on to be rethrown or reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExceptionDescribewritesException in thread ...to native stderr and the stack trace toSystem.err. The prefixes piled up unterminated until a native line ended them (on macOS the Java2D GL warning duringVideoViewTests), and setup-java's problem matcher turned that line into a failure annotation on every macOS test job, green or not.LogSinkprints the stack trace instead, since WebRTC holds its logging lock there.ExceptionCheckno longer describes the exception it rethrows.ReportPendingExceptioninJniBoundary.