Repository navigation
fix: pass media paths to FFmpeg as UTF-8 - #446
Merged
Merged
Conversation
JNI's modified UTF-8 writes characters beyond the Basic Multilingual Plane as surrogates, so FFmpeg could not open or create files with such names. Strings now cross the JNI boundary as UTF-16 and are encoded as UTF-8, and messages back to Java are encoded as modified UTF-8. A source with a null character is rejected instead of being cut short.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaReader and MediaRecorder handed JNI's modified UTF-8 to FFmpeg, which writes characters beyond the Basic Multilingual Plane (emoji and the like) as surrogates, so such files could not be opened or were created under a mangled name.
Strings now cross the JNI boundary as UTF-16 and are encoded as UTF-8; messages back to Java are encoded as modified UTF-8. A source containing a null character is rejected instead of being cut short.