Repository navigation
fix: keep local track releases independent of handlers and cancelled futures - #444
Merged
Merged
Conversation
…futures Ended and device handlers run on an event executor of local media, after the release completed internally. Lifecycle futures are handed out as copies, so cancelling one no longer fails the runtime's close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalTrack.onEndedandDevices.onChangehandlers, and the futures of camera and device switches, run on an event executor of local media instead of the media executor. A track is released first, so a handler that waits for a close no longer deadlocks; the wait is refused with aBlockingCallException.LocalTrack.closeAsync,WebRtc.closeAsync,Peer.whenClosed/closeAsync/whenConnected,DataChannel.whenOpen,HttpSession.closeAsync) are handed out as copies. Cancelling one no longer fails the runtime's close or affects other callers.