Repository navigation
fix: harden JNI error handling - #410
Merged
Merged
Conversation
…llocates 86 entry points let a C++ exception, such as a JavaWrappedException from a conversion helper, cross the JNI boundary, which aborts the VM; they now rethrow it as a Java exception like the others.
…fer natives Null results of GetByteArrayElements went unchecked, AudioProcessing leaked both arrays on its early return, and processStream read and wrote past arrays shorter than the configured frame; it now returns kBadDataLengthError for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioProcessing.processStream/processReverseStreamreturnkBadDataLengthErrorfor arrays shorter than the frame instead of reading and writing past them.