[NikoFoutsitzis]

This PR cleanup #2385

Implemented changes:

• Changed IdeLogListener.onLog(IdeLogLevel, String, String, Object[], Throwable) to IdeLogListener.onLog(IdeLogEntry entry)
• Changed timestamp in IdeLogEntry from long to Instant
• IdeGuiLogListener shows each message only once now + added IdeTestGuiLogListener
• appendOut() in ConsoleController only accepts IdeLogEntry as a parameter now, removed appendOutput(String) and appendOutput(IdeLogLevel, String) in ConsoleController

---

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1. Run the test IdeTestGuiLogListener.
2. Test should be succesfull, IdeGuiLogListener should only show each message once

---

[NikoFoutsitzis]

ConsolePanelTest: In the testmessage "Hello World!" was missing "!" so the test failed.

[coveralls]

Coverage Report for CI Build 39765794280

Coverage decreased (-0.02%) to 74.981%

Details

• Coverage decreased (-0.02%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 20 coverage regressions across 5 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

20 previously-covered lines in 5 files lost coverage.

File	Lines Losing Coverage	Coverage
com/devonfw/ide/gui/core/service/CommandletService.java	13	25.0%
com/devonfw/tools/ide/log/IdeLogEntry.java	3	90.0%
com/devonfw/tools/ide/version/VersionSegment.java	2	90.29%
com/devonfw/tools/ide/log/IdeLogListenerNone.java	1	50.0%
com/devonfw/tools/ide/os/MacOsHelper.java	1	75.63%

---

Coverage Stats

Relevant Lines:	19677
Covered Lines:	15397
Line Coverage:	78.25%
Relevant Branches:	8741
Covered Branches:	5911
Branch Coverage:	67.62%
Branches in Coverage %:	Yes
Coverage Strength:	3.36 hits per line

---

💛 - Coveralls

[quando632]

Nice work @NikoFoutsitzis! Passing the whole IdeLogEntry through onLog simplifies every listener, and IdeGuiLogListener now fixes the duplicate output at the root.
The Instant timestamp with a constant formatter and the recording ConsoleController that avoids the JavaFX toolkit in the test are clean touches as well.

[JoelAdbu]

@NikoFoutsitzis thank you for the PR. The cleanup looks good overall, just two minor suggestions. It would also be worth adding a small test for IdeLogEntry covering the constructor edge cases

[quando632]

Thanks @NikoFoutsitzis, all the earlier points are in and the merge onto the reworked console was done cleanly.

[quando632]

Thanks @NikoFoutsitzis, the null check, the duplicate error event and the static context cleanup are all sorted, nice work!
The merge onto the event-bus console is clean apart from one spot where the original entry got lost again.

[quando632]

Thanks @NikoFoutsitzis, the listener now forwards the original entry, CI is green again and the null-message case is covered, nice work!
Only two small test touch-ups are left.