You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cleanup GUI context injection for NlsService #2589
In PR #2548, NlsService was changed to support an injected IdeContext so that NlsServiceTest can run in an isolated environment without being influenced by the IDE_OPTIONS environment variable.
However, when NlsService is created by the GUI without an injected context, it still lazily creates an IdeContextConsole in createUserEnvironmentVariables(). This was identified during review as an existing architectural hack that should be fixed.
Refactor the GUI integration so that NlsService always receives an appropriate IdeContext through dependency injection. Once all GUI call sites have been updated, remove the fallback lazy creation of IdeContextConsole from NlsService.
Acceptance criteria:
GUI call sites create or provide the appropriate IdeContext when constructing NlsService.
NlsService no longer needs a fallback IdeContextConsole when no context is injected.
Existing locale handling and IDE_OPTIONS isolation behavior remain unchanged.
Activity
laim2003 commentedon Oct 14, 2026
Will be closed by: #2648
devonfw#2589: isolate AppBaseTest's NlsService from the real user home
Merge upstream/main into feature/2589-nls-service-context-injection
#2589: Inject an application-level IdeContext into NlsService from th… (