compiler: Revamp bug-async-degree opt-option - #3023
Open
FabioLuporini wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 83.77% 83.80% +0.02%
==========================================
Files 257 257
Lines 55007 55082 +75
Branches 4708 4715 +7
==========================================
+ Hits 46083 46161 +78
+ Misses 8109 8107 -2
+ Partials 815 814 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Sep 9, 2026
Comment on lines
+266
to
+270
| async_degree = oo['buf-async-degree'] | ||
| if async_degree is not None and ( | ||
| isinstance(async_degree, bool) or | ||
| not is_integer(async_degree) or async_degree < 0 | ||
| ): |
Contributor
There was a problem hiding this comment.
Is there some way to express this more concisely?
|
|
||
|
|
||
| def test_read_only_backwards(): | ||
| @pytest.mark.parametrize('async_degree', [None, 4]) |
Contributor
There was a problem hiding this comment.
Should another check be added to this test to ensure this parameterisation results in the desired effect in the gencode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.