Repository navigation
Conversation
Keep normal 202 and 203 notifications on the existing target session without treating them as shot receipts or bridge readiness. Preserve strict envelopes and exact payload forwarding, with synthetic session regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add fixed 202/203 observation events without response values, plus explicit base-versus-head notification, privacy and receipt-timeout regression coverage for efficacy assessment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The GSPro response profile rejects normal 202 and 203 session notifications and closes the target connection. Admit those two codes through the existing strict response-envelope checks and relay their bytes unchanged.
Neither notification settles a pending shot receipt, produces a success ACK, or sets bridge readiness. Infinite Tees behavior, outgoing shot bytes and framing, numeric spelling, unknown fields, receipt deadlines, and uncertain-delivery/no-replay rules remain unchanged. Update the protocol and diagnostics manuals to match.
Add only two fixed diagnostic classifications for validated GSPro 202/203 notifications. The bounded existing event sink records no response text, player values, raw frames or shot data. No arbitrary response-schema collection or broader telemetry is added.
Efficacy evidence
make cipass with the pinned toolchain, including unit tests, vet, race tests and workflow lint. Hosted portable, input and Windows checks pass for the updated head.This proves the response-policy fix offline. It does not reproduce the user's actual unknown rejected frame or establish that the missed-shot/visible-flight failure is fixed. Upstream 202/203 passthrough uses the existing non-200 relay used by Infinite Tees; its effect on real Labs behavior still needs separately approved qualification.
No simulator access, deployment, additional live test, vendor modification, capture, merge, tag or release is included. The CI portable candidate is for an explicitly authorized test, not a published release.