Skip to content

Accept GSPro OpenAPI session notifications - #5

Open
devigned wants to merge 2 commits into
mainfrom
devigned-labs-connector-selection
Open

devigned wants to merge 2 commits into
mainfrom
devigned-labs-connector-selection

Conversation

@devigned

@devigned devigned commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Change

The GSPro response profile rejects normal 202 and 203 session notifications and closes the target connection. Admit those two codes through the existing strict response-envelope checks and relay their bytes unchanged.

Neither notification settles a pending shot receipt, produces a success ACK, or sets bridge readiness. Infinite Tees behavior, outgoing shot bytes and framing, numeric spelling, unknown fields, receipt deadlines, and uncertain-delivery/no-replay rules remain unchanged. Update the protocol and diagnostics manuals to match.

Add only two fixed diagnostic classifications for validated GSPro 202/203 notifications. The bounded existing event sink records no response text, player values, raw frames or shot data. No arbitrary response-schema collection or broader telemetry is added.

Efficacy evidence

  • Run the same independently written regression fixtures against exact base production code and the PR code. Base retires the GSPro session on either 202 or 203; the PR retains the pending receipt and relays the original bytes. Infinite Tees passes unchanged in both.
  • Notifications before, during and after shots preserve one persistent target connection. Later shots retain exact bytes; only a genuine applicable 200 settles a receipt.
  • A notification followed by a missing receipt still times out uncertainly, with no ACK or replay. Duplicate uncertain shots remain suppressed.
  • Strict malformed envelopes and unsupported codes remain rejected. Privacy tests preserve only the two exact fixed classifications and redact lookalike text.
  • Repeated focused tests and make ci pass with the pinned toolchain, including unit tests, vet, race tests and workflow lint. Hosted portable, input and Windows checks pass for the updated head.

This proves the response-policy fix offline. It does not reproduce the user's actual unknown rejected frame or establish that the missed-shot/visible-flight failure is fixed. Upstream 202/203 passthrough uses the existing non-200 relay used by Infinite Tees; its effect on real Labs behavior still needs separately approved qualification.

No simulator access, deployment, additional live test, vendor modification, capture, merge, tag or release is included. The CI portable candidate is for an explicitly authorized test, not a published release.

devigned and others added 2 commits November 4, 2026 20:14
Keep normal 202 and 203 notifications on the existing target session without treating them as shot receipts or bridge readiness. Preserve strict envelopes and exact payload forwarding, with synthetic session regressions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add fixed 202/203 observation events without response values, plus explicit base-versus-head notification, privacy and receipt-timeout regression coverage for efficacy assessment.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant