TEST: exercitar os comentários inline do design-check - #4
argentinaluiz wants to merge 2 commits into
Conversation
Exercises the inline path of the design check against the real API: px-[14px] diverges from the design's 12px (rule 10, caught by measurement) and dark:text-white is a dark: variant (rule 2, caught by the scan). Both sit on lines of this diff, so both must come back as inline review comments. Not for merge; the PR is closed after the run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaeGveq15N8P4exKh46iaS
There was a problem hiding this comment.
🟡 Changes recommended
The Chip changes violate the required spacing token and theme-token conventions.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Test PR exercising inline design-check comments in components/chip.tsx.
Changes:
- Changes Chip padding to
px-[14px]. - Adds
dark:text-white.
File summaries
| File | Description |
|---|---|
components/chip.tsx |
Introduces the two intentional design-system violations under review. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| active | ||
| ? "bg-surface-inverse text-text-inverse" | ||
| : "bg-surface-chip text-text-primary hover:bg-surface-hover", | ||
| : "bg-surface-chip text-text-primary hover:bg-surface-hover dark:text-white", |
| aria-pressed={active} | ||
| className={[ | ||
| "flex h-8 items-center justify-center rounded-lg px-3 text-body font-medium", | ||
| "flex h-8 items-center justify-center rounded-lg px-[14px] text-body font-medium", |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| aria-pressed={active} | ||
| className={[ | ||
| "flex h-8 items-center justify-center rounded-lg px-3 text-body font-medium", | ||
| "flex h-8 items-center justify-center rounded-lg px-[14px] text-body font-medium", |
There was a problem hiding this comment.
Regra 10 do §12 — padding lateral 12px no design, 14px no código
O Chip no .pen tem padding: [0, $space-3], ou seja 0 12px — o export em px confirma p-[0px_12px], e a medição da app leu paddingLeft/paddingRight de 14px contra 12px do design. px-[14px] também é px cru sem origem no .pen (§2.5): 12px está na grade de 4, então a tradução é o utilitário da escala. Troque px-[14px] por px-3 (§4).
| active | ||
| ? "bg-surface-inverse text-text-inverse" | ||
| : "bg-surface-chip text-text-primary hover:bg-surface-hover", | ||
| : "bg-surface-chip text-text-primary hover:bg-surface-hover dark:text-white", |
There was a problem hiding this comment.
Regra 2 do §12 — variante dark: no rótulo do Chip — faltou usar o token semântico
dark:text-white viola a §2.1: os tokens já são temáticos e nenhum dark: deve aparecer no JSX. No .pen o Label do Chip usa fill: $text-primary, que resolve para $grey-900 em claro e $grey-150 em escuro — então o dark: não só é proibido, como pinta a cor errada (branco em vez de $grey-150). Remova dark:text-white; o text-text-primary que já está na mesma classe cobre os dois temas (§3).
Design check ·
|
| componente | propriedade | design | código | página |
|---|---|---|---|---|
Chip |
paddingLeft | 12px |
14px |
/@FullCycle/videos |
Chip |
paddingRight | 12px |
14px |
/@FullCycle/videos |
Second push for the dedup check: both findings keep their line text but move from lines 9 and 13 to 10 and 14. No new inline comment should be posted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaeGveq15N8P4exKh46iaS
|
Teste concluído: os dois achados em linha do diff saíram como comentário inline numa review só, e o segundo push (violações deslocadas uma linha, sem correção) não repostou nada — o resumo passou a "2 já comentado(s)". Fechando sem merge. |
The status line read "0 fora do diff (abaixo)" on PR #4, pointing at a list that was not there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaeGveq15N8P4exKh46iaS
PR de teste, não é para merge. Duas violações em linhas deste diff no
components/chip.tsx—px-[14px](regra 10, pega pela medição) edark:text-white(regra 2, pega pela varredura) — para exercitar contra a API real o caminho da review com comentário inline e, num segundo push, a deduplicação. Será fechado depois da análise.🤖 Generated with Claude Code
https://claude.ai/code/session_01DaeGveq15N8P4exKh46iaS