Repository navigation
#425 を実装する（スプリント m10a） - #438
Merged
Merged
Conversation
bin/devbase の ${DEV_SERVICE_NAME:-dev} と同じ読み方に揃える。空白だけの値はそのまま返す。
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
takemi-ohama
marked this pull request as ready for review
October 7, 2026 05:11
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
空の DEV_SERVICE_NAME を未設定と同じに扱い、開発サービス名が既定の dev になるようにしました。あわせて仕様書の既定値の記述を「未設定か空なら dev」へ揃え、CHANGELOG に追記しています。課題は #425 です。
利用者向けの変化
移行の手順
変更の要点
lib/devbase/volume/compose.py: 開発サービス名を決めるときに、空の DEV_SERVICE_NAME を未設定と同じに扱い、dev を返すdocs/specifications/compose-profiles.md・docs/specifications/editor-open.md: 開発サービス名の既定を「未設定か空なら dev」へ揃えたCHANGELOG.md: この変更を追記したテスト
tests/volume/test_compose_dev_service_name.pyを追加し、開発サービス名の決まり方を確かめるテストを加えたモード: standard / 通した工程: 実装 → 完了判定 → Pull Request
🤖 Generated with Claude Code