Repository navigation
#2104 を実装する(スプリント m2087) - #2150
Merged
Merged
Conversation
normal の promote は承認ゲート 2 で止まるときに昇格の PR の先端を「承認したコミット」として 承認資料と metrics.approved_sha に載せる。promote-approved は --approved-from の資料の SHA と 先端を照合し、違えば head_moved で止まって承認ゲート 2 からのやり直しを next に示す。 資料を読めないときと、--gate-approved user に資料が無いときは gh を呼ばずに 2 で止まる。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s.py を 500 行に収める(#2104) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
昇格の承認の後に行うマージで、承認ゲート 2 の承認資料の先端と照合するようにしました(#2104)。あわせて promote の用意と照合の引数を
merged_lib/merge.pyへ寄せ、pace.mdと確定仕様にこの照合を書きました。利用者向けの変化
--approved-fromで渡す移行の手順
変更の要点
plugins/ndf/scripts/merged_lib/merge.py: 昇格の承認の後のマージで、承認ゲート 2 の承認資料の先端と照合する処理を足した。promote の用意と照合の引数もここへ寄せた。plugins/ndf/scripts/merged-steps.py: 引数の処理をmerged_lib/merge.pyへ移し、500 行に収めた。plugins/ndf/scripts/merged_lib/checks.pyとplugins/ndf/scripts/supervise_lib/delivery_templates.py: 照合の追加に合わせて直した。docs/specifications/ndf-release-approved-commit.mdとplugins/ndf/skills/development-workflow/references/pace.md: 昇格の承認の後の照合を書いた。docs/specifications/README.md: 確定仕様の索引に、昇格の承認の後の照合(--approved-from)を足した。テスト
supervise.pyの run のステップはすべて exit 0 で終わりました。sprint/m2087は進んでいないissues/issue-2104-design.mdに名前の出るテスト 2 件がすべて HEAD にあるテストには
test_sprint_close_merge_green.pyとtest_supervise_pace_verify.pyへの追加と修正が含まれます。設計と違う点
モード: standard / 通した工程: 実装 → 完了判定 → Pull Request
🤖 Generated with Claude Code