Repository navigation
Conversation
The API docs page reuses the operations console's shell: the sidebar of grouped pages, the header naming the current one, the mobile nav that scrolls sideways, the theme switch and the way back to /dev/null. ConsoleLayout now draws that shell from its props: the brand chip and label, the nav landmark's own label, whether its links prefetch, and a title that falls back to the console's name. OperationsLayout keeps what only operations does (polling, refreshing, the remotes dock) and passes its pages in, with Moderation as an item elsewhere and prefetch off, as before. Nothing changes on screen: captures before and after differ only in the pulsing live dot. Two things only the API docs will use come with it, as part of the shell: links that prefetch, which operations leaves off, and the way back for a guest on a phone, since operations only has signed-in admins.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Summary
First of five pull requests splitting #1533 (the API docs page) so it can be reviewed in steps. The API docs reuse the Operations console's shell, so this one only moves that shell out of
OperationsLayoutinto a sharedConsoleLayout. Nothing changes on screen.Changes
ConsoleLayoutdraws the shell from its props: the sidebar of grouped pages, the header naming the current one, the mobile nav that scrolls sideways, the theme switch and the way back to /dev/null (a guest finds it on a phone too).OperationsLayoutkeeps what only Operations does (polling, refreshing, the remotes dock) and passes its pages in, with Moderation as an item elsewhere and prefetch off, as before.Two options of
ConsoleLayoutare only used by the API docs, from #1643 on: links that prefetch (Operations leaves it off) and the way back for a guest on a phone (Operations only has signed-in admins). They are part of the shell, so they come with it, tested.The stack, each opened as a draft until the one below it merges:
productionValidation
tests/draft-images.config.ts)ConsoleLayout.test.tsx12tscvp fmt --check,vp lintNo PHP changes.
Visual evidence
Playwright (Chromium) against a local dev server, emulated viewports. Operations was captured before (
production) and after at 1440×900, 1366×650 and 390×844, light and dark, while this change was part of #1533; the pairs differ only in the pulsing live dot. The commit is unchanged since, only rebased.Device verification
Emulation only (390×844, DPR 2, touch): no hardware or simulator.
Independent review
Fresh read-only reviewers, given the guidelines, the stack, the validation results and the captures. A first round on the previous heads found should-fix points (fixtures and options ahead of their PR, the Errors table hiding its meanings on a phone, the Guilds preview, captures from before production's guild fields), all fixed. Re-review on base
1aa85cf4, head6e94300c: CODE: PASS, VISUAL: PASS, no blocker or should-fix. The Operations captures were checked against this exact layout code.Limitations
None.
Summary by CodeRabbit