Repository navigation
chore: remove Vue CLI leftovers and fix the ESLint setup (BITS-213) - #26
Merged
Merged
Conversation
Neither Vite nor Storybook used babel.config.js, @vue/cli-plugin-babel or @vue/cli-plugin-eslint. Removing them drops 342 dev packages, including @vue/cli-service, webpack-dev-server, yorkie and the websocket-driver and shell-quote advisories. The lockfile change is the npm uninstall only. ESLint loads again: the missing @vue/prettier/@typescript-eslint preset is gone. New `npm run lint` script, also run in CI. Rules turned off because they fight the code style, not bugs: - formatting checks (skip-formatting): templates wrap long class lists by hand - vue/multi-word-component-names: components are named after their file - no-explicit-any in stories: the any hides type errors on story args - no-empty-function in tests: browser API stubs do nothing on purpose Removed unused imports and an unused parameter in three src files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 11, 2026
PhilReinking
left a comment
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 6a84c1d, CI green. One should inline.
Checked beyond the PR text: on main ESLint doesn't start, here it covers 49 files (all but .storybook/). With the rules you turned off back on, lint flags only one-word component names, any in Menu.stories.ts, two test stubs and mostly hand-wrapped class lists, so turning them off is fair. The lockfile only removes entries; dist, the prod tree and the prod audit match main.
| "author": "Philipp Reinking <philipp@deck9.co> (https://deck9.co)", | ||
| "scripts": { | ||
| "check": "vue-tsc --noEmit", | ||
| "lint": "eslint .", |
Contributor
Author
There was a problem hiding this comment.
Should: unused imports are only warnings here, so eslint . exits 0 when someone adds back the onMounted/watchEffect this PR removes (I tried). --max-warnings 0 fails on that and passes on this branch.
Suggested change
| "lint": "eslint .", | |
| "lint": "eslint . --max-warnings 0", |
Unused imports are only warnings, so plain eslint exited 0 on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
babel.config.js, @vue/cli-plugin-babel and @vue/cli-plugin-eslint, which neither Vite nor Storybook used, and makes ESLint load again with a newnpm run lintscript.Fixes BITS-213
npm uninstallonly: 342 dev packages removed, nothing added or upgraded. The runtime tree is the same as on main.vue/multi-word-component-names,no-explicit-anyin stories,no-empty-functionin tests.npm run lintafternpm ci.src/: removed unused imports inMenuContainer.vueandTextarea.stories.ts, and an unused parameter inIcon.stories.ts.Tested: lint, check, test, build and the dist type-check pass. dist is byte-identical to main, Storybook builds the same stories, lint fails on a planted bug.
Not tested: clicking through Storybook by hand.
npm audit
No websocket-driver or shell-quote advisory left. Total advisories 122 → 86, critical 8 → 6. Still critical (all dev only): form-data, handlebars, proxy-addr, tar, tinypool, vitest.
🤖 Generated with Claude Code