Repository navigation
fix: write D9Skeleton's margin classes in full and rebuild lines on change (BITS-212) - #25
Merged
Merged
Conversation
…hange (BITS-212)
Tailwind only generates classes it finds written out, so the runtime
`mr-${n}` left six of the eight line widths without CSS in Input. The
lines are now a computed over a clamped, floored count, so -1 or 2.5
no longer throw and a new `lines` value re-renders.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 11, 2026
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at 87b7ac6, CI green.
Checked against main: Input's own Tailwind (3.4.19) on this build emits all 8 .ipt .mr-N rules, on main only mr-4 and mr-6. The 3 new specs fail on main's Skeleton.vue. Widths stay the same on unrelated re-renders and re-roll only when lines changes. NaN, null and 0.5 render no lines and no gap; Infinity still throws, as on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D9Skeleton now writes its eight line margin classes out in full, so Input's Tailwind generates them and the loader lines get varied widths again. On main, Input's CSS has only mr-4 and mr-6, so most lines render full width. The lines are also a computed now:
linesof -1 or 2.5 no longer throw, and a newlinesvalue re-renders.Fixes BITS-212
linesround down, negative ones render none. The line block hides when the count rounds to 0, so 0.5 leaves no empty gap.lineschange re-rolls all widths, not only the new lines.Tested: check, build and tests pass, and the new spec fails on main. Input's Tailwind build has all 8 classes with this branch. Storybook checked in Brave.
Not tested: Input's dashboard itself in a browser, and Chrome, Safari or Firefox by hand.
🤖 Generated with Claude Code