Repository navigation
Preserve signed release images across buildfs cleanup - #282
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Packaging Failure
Preparation run 42518086427 passed firmware compilation and its version check, but the subsequent filesystem build cleaned the environment directory. Packaging then could not find firmware.bin. No signing, draft, or asset creation occurred.
Fix
Preserve firmware.bin, bootloader.bin, and partitions.bin outside the build directory before buildfs; restore their exact bytes afterward. This follows the existing custom-build runner pattern and keeps manifest generation, four-image ZIP verification, and signed evidence on their existing canonical paths. The filesystem remains the freshly built image. No firmware, SDK, dependency, signature policy, or tag changes.
Validation
The focused workflow regression executes the actual shell step against a mock buildfs that deletes the entire build directory, then checks all four resulting images byte-for-byte. It and raw whitespace checks passed. Require reviewer-agent review and relevant CI before merge.
The immutable v3.1.16 tag remains at 8e21742. Resume a new Release firmware dispatch from reviewed main against that same candidate, previous_tag=v3.1.15, bootstrap_catalog=false; retain all mandatory preflights.