Repository navigation
ST7789P3 support #10
Description
There is a variant of ST7789 named P3, what is the best way to support this variant? I tried adding support but it seems to require a lot of changes.
The only difference is that for P3, we need to set 0xC5 instead of 0xC4. Maybe add an option<u8> to it? Or using traits ST7789P3Specs: ST7789Specs or ST7789Specs<P3>?
/// VDV Set (0xC4) - 1 byte: Default ST7789 only
const VDVS_PARAM: u8;
/// VCOM Offset Set (0xC5) - 1 byte: ST7789P3 only
const VCMOFSET_PARAM: u8;
Activity
decaday commentedon Sep 23, 2026
Thanks a lot for bringing this up!
After an initial look, I feel we can just go with
Option<&'static [u8; 1]>.Changing the traits would add too much complexity and cause potential issues with inheritance. Since this project prefers a practical design, I'd rather avoid complicating the traits.
decaday commentedon Oct 3, 2026
Closing as #11 has been merged.