Repository navigation
feat(web): errors and setup warnings link to the page that fixes them - #189
Merged
Merged
Conversation
Surfaces are now separated by tone (canvas, surface, well, raised), not by lines: every border token is transparent, and inputs, selects, textareas and checkboxes are filled instead of outlined. The blue-tinted greys are replaced by neutral ones. The primary action is high-contrast neutral; blue is kept for links and the focus ring only. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
A toast whose message points somewhere ("add a key in Settings") now carries
a button to that exact page and settings section. Settings opens the section
named in ?tab=. The needs-setup marker in a workbook cell links to the
section for that reason instead of the settings root.
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
|
All contributors on this pull request have signed the OpenGTM CLA. Thank you! Agreement: OpenGTM CLA 1.0
|
A tab left open across an upgrade asked for page files the new build had replaced and showed the error page. It now reloads once to pick up the new build; if that does not help, the error page says the app was updated. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #188 (contains its commit).
lib/notify.tswraps the toast API. An error, warning or info toast whose message names a place gets an action button to it, for example "No AI provider configured. Go to Settings to add an API key." gets Open AI provider settings.?tab=; an unknown value falls back to AI Providers.toastfromsonnerdirectly.Checked: build, lint, 219 unit tests, accessibility suite (64 of 64, including the new deep-link test).
Not exercised in a browser: clicking the action button on a live toast.