Repository navigation
fix: first-run fill rate (limiter, cooldown policy, re-run keep, Email Verify, reasons) - #182
Merged
Merged
Conversation
…tegy Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Nine declarative manifests (Anymail Finder, Bouncer, MillionVerifier, Findymail, ContactOut) with docs-derived fixtures and one generic test, a wiring test across catalog, workbook and settings registries, and a rewritten manifest format guide. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Replace every native confirm/prompt with useConfirm()/usePrompt() (focus managed, destructive style, named objects). Fix target-size at shared level via --gtm-target-min (accounts for the shell's CSS zoom), fix contrast and unnamed controls, add six routes to the axe gate, and empty the baseline. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ls; changelog for the Go cutover Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…_verify words response.value_maps translates a mapped value with an explicit default, request.omit_empty drops empty headers, query parameters and body keys, and values substituted into request.url are escaped. The three verifier manifests now emit only valid, invalid, catch_all, risky, unknown. Adds Settings key cards for LeadMagic and Prospeo. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Audience and automation delivery adds a lead to a HeyReach (LinkedIn) or lemlist (email) campaign with the workspace's own API key. Workbook output columns are not part of this change. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…ints Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Upserts each member as an Attio person matched on email and links or creates its company by domain, with the workspace's own token. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nto train/2026-11-19
…o train/2026-11-19
… train/2026-11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…11-19 # Conflicts: # apps/backend-go/internal/settings/registry.json
…rain/2026-11-19 # Conflicts: # apps/web/src/components/command-menu-content.tsx
…ucing script Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…fix/first-run-fill-rate
…eep the queue wait off the provider timeout Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…s, one shared policy for both write paths Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
… notes the failed attempt Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
… column graph and stores the verifier's answer Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
… cooling down, browser service Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…olumn, link Email Verify to Email Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…luding key-requiring columns as separate numbers Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…mbers, remaining causes Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
|
All contributors on this pull request have signed the OpenGTM CLA. Thank you! Agreement: OpenGTM CLA 1.0
|
… (upstream, target site, local) Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…n; concurrent timeouts count as one event Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Drives the built app against a running stack (setup, Get started, sample run, every route in light and dark, one action per area), records API statuses, console output and error states, and writes screenshots and findings.json. Separate config and script; not part of test:a11y and not run in CI. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…nalytics trend contrast The mocked suite answered unmatched endpoints with [], so /overview, /analytics and /settings rendered their error states (or a skeleton) and were never audited with content. Add shapes captured from the real API, fail any page that shows an error state, and wait for the query retry before auditing. The analytics page, now rendered with data, exposed low-contrast trend text (emerald-500 and red-400 on white); use the 700/400 pair. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
Loading the sample completes step 3, and done steps carry no actions, so Open it from step 3 pointed at nothing. The workbook link is step 4's. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
The list search cast accepted_fields to text, so domain or name (or any short term) matched every record. Search the values with jsonb_each_text. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
… and website_scraper walk a site once per run, not once per column Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…first-run-fill-rate
…, needs_setup, error) Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…d; cells are counted as filled, no_data, needs_setup or error Provider failures that the cell used to hide as no_data (an HTTP 5xx, a missing key) now say so (provider_error, provider_key_missing). Retry passes pick up error cells only. The receipt stores the counts. Tests that encode the old status and count semantics are updated in the next commit. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…statuses The wbexec parity vectors (testdata/wbexec_vectors.json) are unchanged. They record Python's row_result, which counted every cell without a value as an error: provenance_error_cell (1), condition_skip_blocks_dependent (2, one of them a skip) and email_verify_no_value_no_cascade (1). Go now splits those into no_data, needs_setup and error, so the harness compares Python's count with their sum. The run_integration and receipt tests that asserted errors=2 / status=failed for cells that found no data, and the exact receipt key set, now assert the new counts. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
… for real errors The run label reads '86 filled · 89 no data · 25 need setup'. The Run needs attention banner shows only for failed or completed_with_errors workbooks. Cell icons: no data is neutral, needs setup links to Settings. A shared outcome table is checked by both the Go and the TS classifier.
…message The run-history result returns no_data and needs_setup when the receipt has them (older receipts keep their shape); the workbook_status message carries them too.
…ours the keyless backoff ddgs builds a fresh engine set per query and swallows non-200 answers, so a backend that had just said 429 or 403 was asked again on the next query and a dead one cost a full timeout each time. The browser service now remembers each backend's last answer and skips it while it cools down; when all are cooling down the query fails at once as rate_limited. WebSearch now shares the Go keyless backoff. No change to how requests look or where they come from. docs/operations/search-backends.md says the honest answer is your own search key or SearXNG.
… of NewDeps, so no probe was ever sent NewDeps registered the SMTP verifier already bound to the Deps of that moment, before NewLive set NewSession, SMTPDisabled and the HELO identity. Every cascade verification therefore ended 'unknown / unreachable' without opening a connection (port 25 was open; a direct probe returns catch_all or invalid). The verifier is now registered unbound and the cascade binds it, and checks availability, against the Deps it runs with. Also: the probe records where it stopped (Why), and a run of distinct mail servers that all fail to answer while none does marks port 25 as blocked (smtp_port_blocked). An unknown verdict is no longer stored as the cell value: it is no_data (email_inconclusive), needs_setup (blocked port 25, with the text to use a verification provider key; or nothing to ask), or an error (timeout, open breaker).
…st environment-limited columns Email Verify 'unknown' is no fill. Columns whose cells say SMTP port 25 is blocked are reported as environment-limited, with their own rate (excluding_environment_limited) beside the other three.
…h installs Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
…alth test (ruff) Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #175 (train/2026-11-19) and #178 (the benchmark). The diff includes both until they merge. Fixes the causes of the low first-run fill rate of the sample workbook found in #178. Commits are small and test first.
What changed
Browser and providers
BROWSER_MAX_CONCURRENCY; the queue wait is bounded by the run context and does not count against the provider timeout.deep_scraperandwebsite_scraperwalk a site once per run, not once per column.Cooldown
internal/cooldownfor both write paths: a rate limit keeps the 300 s cooldown; a timeout cools down only after 3 consecutive timeouts; a timeout of a target-site provider never cools it down; concurrent timeouts count as one event. Migrations 00006 and 00007 (consecutive timeouts, last timeout time).WebSearchhonours the keyless backoff.Cells and re-runs
Email Verify
DepsofNewDeps, so no SMTP probe was ever sent (fix 9efeb94; test sends a probe through the cascade).Outcome and status model (
internal/cellstate)filled,no_data,needs_setuporerror. A run ends ascomplete(no errors; cells with no data are not failures),completed_with_errors(some real errors) orfailed(nothing completed). Run history and the status message carry the counts. The web app showsno_dataandneeds_setupas neutral outcomes and uses red only for real errors.Demo and benchmark
scripts/bench/first-run-fill-rate.shreports four separate rates (all filled; excluding guessed emails; excluding key-requiring columns; excluding environment-limited columns). A cell is filled only when it carries an informative value.Numbers (200 enrichment cells, zero keys, two fresh installs each)
Round 2 Email Verify statuses (install 1 / 2): valid 3 / 5, catch_all 19 / 19, invalid 1 / 0, empty (
no_mx) 2 / 1. Without the catch_all cells the all-filled rate would be 72.5% / 73.0% (from the cell files, not a script number). Workerprovider timed outwarnings: 3 and 7 (round 1: 137 and 144). The filled rule was tightened between rounds, so round 1 is not strictly like for like. Remaining empty cells: HQ Location (25, needs an LLM key), phone 6 / 5, size 2 / 2, hiring 1 / 2, Email Verify 2 / 1. Details, per-column tables and evidence:docs/benchmarks/2026-11-first-run-fill-rate.md.Tests run (apps/backend-go, head: the last commit on the branch)
gofmt -l .(clean),go vet ./...,go vet -tags integration ./...,go build ./...: clean.go test -count=1on the 37 Go packages changed on the branch: all ok.go test -tags integration -count=1 -p 2on the same packages exceptinternal/api, against a fresh migrated database and Redis DB 9: all ok.go test -tags integration -count=1 -timeout 40m ./internal/api(595 s): 2 tests fail,TestIntegrationRoutesMatchFixturesandTestSettingsRoutesMatchRecordedFixtures, both on the integrations list ($.integrations[2]is Attio, the fixture expects Airtable). Not caused by this branch: the branch does not touch those fixtures or code, and the failing CI job on this PR shows the same two. The fix is in train/2026-11-19 (commits 205f179 and 31190f4 add Attio, HeyReach and lemlist to the recorded fixtures); this branch only carries an older partial merge of the train. It goes away when Release train 2026-11-19: PRs #166 to #181 combined #175 merges and this branch is updated. All other api tests passed, includingTestPersonWSNoInternalErrorTextLeaked.bun install --frozen-lockfile,bun run lint,bun test tests(208 pass),bun run build,bun run test:a11y(52 passed): all clean.tests/test_search_backend_health.py; fixed in a new commit. Thenuv run --frozen ruff check .andruff format --check .clean,uv run --frozen pytest -q249 passed.scripts/bench/first-run-fill-rate.shtwice in a row on commit baa6b66 (docs only after that).Not verified
catch_allverify cells count as filled by the script's rule.