Repository navigation
Conversation
Refactor send_deal endpoint to use sendManualAndSave method for handling deals and saving to the database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/send_deal currently submits a manual proposal without persisting the returned deal. A successful response can therefore have ID 0 even though the provider accepted the proposal.
We encountered this using an external controller for per-deal admission, pacing and duplicate checks beyond our scheduled submission workflow. API clients need persistence equivalent to CLI deal send-manual --save without direct database write access.
This change calls the existing proposal handler once, then saves the accepted model using database.DoRetry and returns its generated ID. Only persistence is retried; the network proposal is not replayed. The shared handler, CLI behavior and database schema remain unchanged.
Validation: the equivalent deployed wrapper passed persistence/rejection tests and live validation on our pinned revision. Current-main tests have not been run. This draft still needs Go formatting and regression tests added.
Provider acceptance and persistence are not atomic. A save failure after acceptance requires reconciliation before resubmission.