Repository navigation
fix: link transaction hash directly and clarify queued copy - #71
Merged
Merged
Conversation
Make the transaction hash itself the Etherscan link instead of a separate "here" link, and reword the release queued message so it does not imply a scheduled processing order. Also fix the component name/props to match the file and replace toLocaleLowerCase with toLowerCase for repo addresses.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improves the "Release queued" screen shown after publishing.
IntroductionSteptoReleasePublishedto match the file.toLocaleLowerCase()withtoLowerCase()for repo addresses.classNameprop to the sharedLinkcomponent.Why
The transaction hash was displayed as plain text with the actual link hidden behind a separate "here" link. Making the hash clickable is clearer and removes the redundant sentence.
The previous copy ("processed sooner or later based on the gas fee you provided") read as outdated and implied a scheduled processing order. A queued transaction is not processed on a schedule; it is included in a block once its gas fee becomes competitive, so the copy now says that directly.
Notes
toLocaleLowerCase()is locale-sensitive and is the wrong tool for lowercasing an address.break-allwas added to the hash link so the 66-character hash wraps instead of overflowing the card.Verification
npx tsc --noEmitpasses with no errors.The app was run locally and the screen was rendered and screenshotted. Rendered output: