Repository navigation
Wait for the network before fetching IPFS manifests on first boot - #735
Merged
Merged
Conversation
After an ISO install, dappnode_install.sh runs from rc.local, which does not wait for DHCP: Debian configures the NIC as allow-hotplug, and network-online.target does not wait for those. Fetching the NOTIFICATIONS/PREMIUM manifests, the first network access of an ISO install, could therefore run before the machine had an address and abort the installation with "Could not fetch IPFS manifest". Retry the fetch for up to ~2 minutes before giving up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3alpha
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the first boot after a Debian ISO install,
dappnode_install.shruns fromrc.local, which doesn't wait for DHCP. Debian configures the NIC asallow-hotplug, andnetwork-online.targetdoesn't wait for those. The NOTIFICATIONS/PREMIUM versions are bare/ipfs/<cid>refs, so their manifests are fetched over the network. That is the first network access of an ISO install, and it can run before the machine has an address:The installation then aborts on first boot. This reproduced on every Debian E2E run (#731); the gateway itself answers instantly. Ubuntu waits for the network through netplan, so it doesn't hit this.
Fix
Retry the manifest fetch for up to ~2 minutes (24 × 5 s) before giving up, with one warning on stderr (stdout is the function's return value). When the network is already up, nothing changes: the first attempt succeeds.
Verification
🤖 Generated with Claude Code