Repository navigation
Fix Debian ISO installs failing on the cdrom APT source - #734
Merged
Merged
Conversation
Since #732, dappnode_install_pre.sh UPDATE exits when apt-get update fails. During a Debian ISO install it runs as a late-command, before d-i comments out the install media's cdrom: source, so apt-get update always fails with "does not have a Release file". The installer then stops at "Failed to run preseeded command", which hangs unattended installs and affects the v0.3.24 Debian ISOs. Comment out cdrom: sources first on ISO installs, as d-i does right afterwards because of apt-setup/disable-cdrom-entries. Failures from the real repositories still abort the install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3alpha
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #732 (shipped in v0.3.24), Debian ISO installs, both attended and unattended, stop at the end with:
The installer log shows why:
dappnode_install_pre.sh UPDATEruns as a d-i late-command. At that point the target'ssources.liststill contains the install media'sdeb cdrom:entry; d-i comments it out only afterwards (apt-setup/disable-cdrom-entries). Soapt-get updatealways exits non-zero on an ISO install. Before #732 that error was hidden by| tee; #732 correctly made it fatal, and the unattended installer now hangs on the modal error.Fix
On ISO installs only (
ISO_INSTALLATION=true), comment outcdrom:sources beforeapt-get update, the same thing d-i does a moment later. Errors from the real repositories still abort the install, as #732 intended. Ubuntu is unaffected (no active cdrom source), and so are non-ISO installs.Verification
Found by the new unattended USB E2E test (#731). With this change the Debian E2E completes: install, first boot, reboot, and dappmanager running.
🤖 Generated with Claude Code