Repository navigation
docs(forgejo): dind の上限のコメントを、同時に使い切ったときの余りで書く - #922
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8TqVdo6LUrWKdVQgbScVU
|
Claude finished @5ym's task in 12s —— View job レビュー結果コメントのみの変更(値は変更なし)で、動作への影響はありません。 算術: dind 10Gi + denpa 8Gi + CI 以外の実使用 約 10GiB = 28GiB。allocatable 約 28.2GiB との差は 0.2GiB で、記述と合っています。「収まる」を余りが分かる書き方に直した意図も妥当です。 要確認 (軽微): 新しい文言は「全部が同時に上限まで使うと」と書いていますが、同じ Pod の runner コンテナの limit (1Gi、
それ以外に問題はありません。 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T8TqVdo6LUrWKdVQgbScVU
|
Claude finished @5ym's task in 7s —— View job レビュー結果コメントのみの変更で、値は変わっていません。動作への影響は無いです。 前回の指摘(前提の混在)は解消されています。
runner コンテナの limit 1Gi(実測 21Mi)は足し算に入っていませんが、前提が「ほかは実測どおり」と書かれているので、記述と矛盾しません。 問題はありません。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#920 のレビューの指摘。dind 10Gi・denpa 8Gi・CI 以外 約 10GiB を足すと 28GiB で、kubelet の予約後の allocatable (約 28.2GiB) がほぼ埋まる。
コメントの「28 GiB に収まる」を、余りが約 0.2GiB しか無いと分かる書き方にした。値は変えていない。
🤖 Generated with Claude Code
https://claude.ai/code/session_01T8TqVdo6LUrWKdVQgbScVU