Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the Mac installer integrity failure and refine the installation experience based on native acceptance feedback: crisp Retina text, an original guide icon, one selected language across the desktop and tray, a cleanup/uninstall entry, and a smaller native AppKit/WebKit macOS application without bundled Chromium.
Changes
Verification
Current source head:
5e9730c15e43b68573d864edda6020880d614971.bun run check,bun run test:unit(400 passed, 0 failed, 2,388 assertions),bun run test:release,bun run test:portable,PLAYWRIGHT_BROWSERS_PATH=/tmp/crw-playwright bun run test:desktop,node --check tests/browser/macos-native.e2e.mjs,git diff --checkand the home-layout checker passed. Both current Verify runs passed: PR 44227929556 and push 44227923105, including offline release gates, desktop/guide UI, Docker and source candidate checks. PR policy passed. The native workflow failed only its two macOS 27 UI jobs, as detailed below; all runs have final conclusions.af6f29e34ccb63e2a6149925037eb7f3b9951d2a9b93d1d7a177d5d51076023f.screencaptureand ScreenCaptureKit. Independent inline/custom-scheme tests reproduce this across data stores, layer hosting, load order, color space, rasterization, explicit display/transaction flush, normal AppKit entry and a signed minimal app bundle. System Safari opening an original local HTML fixture also shows its blue background without its text/input; the screenshot is in thewebkit-compositor-diagnosticsartifact. This establishes a broader reproduction on that runner, not that this app is proven compatible on another Mac. No private WebKit API or relaxed pixel assertion is used.xcode-27. No successful GPU result or GPU root cause is claimed. The latest same-DMG macOS 27 job failed its actual-screen pixel assertion; mount, Finder installation, signatures and gateway/PTY checks passed. Its SHA-256 matches the macOS 15 report. Both native macOS 27 jobs failed; Linux x64/arm64, Windows x64 and the macOS 15 package jobs passed.Risk and rollback
Maintainer attention: packaging/native signing, source-image allowlist, cleanup/execution boundaries and the CI artifact paths. Cleanup requires an explicit in-app confirmation; no user cleanup is executed by development tests. Active remote deployment receipts are retained until managed removal completes, and stable synchronization files intentionally remain. Filesystem compression depends on a compatible APFS/HFS+ destination; logical file size is reported separately. No dependency upgrades, cloud mutations, production restarts, published release changes or protected merges. Revert the PR to restore previous behavior.
AI assistance
Codex implemented and reviewed the changes and ran the listed tests. Original artwork is drawn in code; screenshots use synthetic fixture data. No human review or personal Mac acceptance is claimed. macOS 15 native results passed; macOS 27 actual-window validation remains unresolved; previous artifact results are retained separately; remaining user acceptance includes Safari/Gatekeeper and real login/logout.
Checklist