Repository navigation
fix(ui): the collapsed rail shows its expand chevron, and opens expanded once - #6706
Conversation
…ded once The collapsed sidebar's header showed the install's brand mark, and swapped it for the expand chevron only on hover, so the control read as a logo on a mouse and as nothing on a touch screen. The person asked for the chevron to stand there always, and for the brand to show only in the expanded sidebar. - Collapsed, the header is one button: the chevron, always drawn, in the nav item's 40px box on the icon column, with the name `Expand navigation`, its tooltip and its hit target unchanged. No brand mark is rendered there. - Expanded, the header keeps its brand mark, its Home action and its `Collapse navigation` chevron as they were. - The stored sidebar state moves to `platform-sidebar-expanded-v2`, so every browser opens the rail expanded once and meets the new layout, and the old key is removed rather than read. The other sidebar keys are untouched. Signed-off-by: Jan Pokorný <JenomPokorny@gmail.com>
There was a problem hiding this comment.
🛡️ Code Guardian 🛡️ — ✅ Code Review @ 133db59
PR #6706: fix(ui): the collapsed rail shows its expand chevron, and opens expanded once
Author: JanPokorny | Branch: fix/collapsed-sidebar-chevron → main | Changes: +34 −18 (5 files)
Summary
This change renders only the expand chevron in the collapsed sidebar header and removes the brand logo there. It also versions the sidebar storage key so every browser opens expanded once and removes the old key.
Limits: 1 skill(s) did not run: issue-fit.
Findings
- 🟢 Suggestion: Navigation rail bullet splits the Agent item (
.quality-inspector/qi-profile-dam/SKILL.md:33).
Documentation Check (doc-drift)
✅ No findings.
TypeScript Engineering Review
✅ No findings.
React UI Engineering Review
✅ No findings.
Verdict
APPROVE — The collapsed header and storage-key reset match the specification and tests, with one minor profile-doc placement suggestion.
Review by Code Guardian 🛡️ · automated code guardian · ibm/gcp/gemini-4-argon on pi
| - **The navigation rail** — expanded by default, with labels; its header carries the install's brand mark, which opens Home, and a *Collapse navigation* chevron beside it. | ||
| Collapsed, the header carries only an *Expand navigation* chevron, always drawn rather than swapped in on hover, and no brand mark or brand text. | ||
| This change opens the rail expanded once in every browser, whatever the person had collapsed before, and their next collapse sticks for that browser. |
There was a problem hiding this comment.
🟢 Suggestion: Inserting The navigation rail at line 33 splits the Agent bullet in two. Lines 36–49 describe the agent chat header and message box, so place this bullet after line 49.
The collapsed sidebar showed the install's brand mark in its header, and swapped it for the expand chevron only on hover.
So on a touch screen the expand control was a logo, and with a mouse it moved under the pointer.
The person asked for the chevron to stand there always, and for the brand to show only in the expanded sidebar.
The same change also opens every browser's sidebar expanded once after this update, so everybody meets the new rail.
Reviewer guide
What changes in substance
Its accessible name (
Expand navigation), its tooltip and its hit target stay as they were, and the chevron is a shape, never a colour alone.BrandLogoSlot, its hover/focus opacity swap and the overlay chevron are gone there.The expanded header keeps its brand mark, its Home action and its
Collapse navigationchevron unchanged.platform-sidebar-expanded-v2. Every browser therefore opens the rail expanded once, whatever it had collapsed before, and stores its own choice under the new key from then on.The old
platform-sidebar-expandedkey is removed on load rather than read, and the other sidebar keys are untouched.This resets a preference on purpose: the point is that everyone meets the new collapsed rail, and a person who wants it collapsed again does that in one click.
Where to look closely
packages/ui/src/modules/platform/store/sidebar.ts— the versioned key.It is read at store creation, so the old key is dropped on the first load of this build and never consulted again.
packages/ui/src/modules/platform/components/sidebar/sidebar-header.tsx— the collapsed button keepsw-full h-10 pl-2.5, so the pointer target covers the rail's header as before, andonConfigure-style behaviour is untouched.Ruled out
Who decided
The release line carries this too
release-v0.3.1holds the same change asa93623467, a cherry-pick of133db5936, taggedv0.3.1-rc.3.The sidebar code, its store and its tests are identical on both lines, so the cherry-pick applied without a conflict.
The patches differ only in
.quality-inspector/qi-profile-dam/SKILL.md: the release line carries fewer vocabulary bullets thanmain, so the new "navigation rail" bullet lands among a shorter list.Issue
No issue tracks this change.
Screenshots
The header rendered in the app's own CSS at the collapsed width (56px), before this change on the left and after it on the right.
And the old behaviour the person reported — the chevron arriving only under the pointer:
Testing
mise run //packages/ui:check— passes.mise run //packages/ui:test— 341 files, 2267 tests pass.mise run check— passes, in the commit hook.release-v0.3.1after the cherry-pick: UI check and 2162 tests.svg[aria-label], one icon with no opacity class), and "opens expanded for a collapse stored under the old key, once" (expanded, old key removed, no new key written).