Skip to content

feat: every review guide publishes into one artifact folder (14.9.0) - #301

Merged
xjacka merged 2 commits into
mainfrom
feat/review-guide-artifact-folder
Nov 7, 2026
Merged

xjacka merged 2 commits into
mainfrom
feat/review-guide-artifact-folder

Conversation

@dam-code-protector

@dam-code-protector dam-code-protector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Review guides publish to the artifact library with no folder, so they mix with
the reports in the operator's artifact list. This change fixes one folder name
in the definition. The publish step resolves the folder PR review artifacts,
creates it when it is absent, and passes its id.

Reviewer guide

What changes in substance

  • Where a guide publishes. Every review guide goes into the owner's folder
    PR review artifacts. The alternative was a work/CONFIG.md key. The
    operator chose a fixed name, so no instance configures it.
  • An old guide moves in. The update call now carries the folder id, so the
    next round of a guide that was created outside the folder moves it. The move
    does not create a version.
  • One failure arm. When the folder call fails, the guide publishes
    ungrouped. A folder problem never costs a review.

Where to look closely

  • docs/artifact.md step 4 and the guide_brief text in scripts/review-pr.sh
    state the same steps, twice. They must stay identical, or the model reads one
    and the doc says the other. The test asserts the folder step in the brief.
  • The fixed name appears in three places in the diff. A future rename needs all
    three, and the folder of an existing guide then moves on its next round.
  • A recorded guide id whose artifact was deleted falls back to a create. That
    path must carry the folder id too, or the new artifact lands ungrouped.

Ruled out

  • A review_artifact_folder configuration key: the operator declined it. A
    folder is one value per instance, not a tuning knob, and a key needs an
    onboarding step, a preflight field and a default.

Gates you changed

  • scripts/tests/test_review_pr.sh gains two assertions for the new step, and
    each create_artifact and update_artifact call of a brief case now has an
    assertion on the whole call, folder_id included. No assertion is removed, skipped or relaxed.
  • scripts/harness/claude-code/denied-tools.txt loses two lines. The guard
    test_install_hook.sh (trim_unused_only) passes again.

Who decided

  • The operator: the folder itself, and a hardcoded name instead of a
    configuration key.
  • (open) The author: the name PR review artifacts, and the ungrouped
    fallback when a folder call fails.

Scope

  • docs/artifact.md — where a guide publishes, publish step 4, self-check.
  • scripts/review-pr.sh — the guide_brief publish steps the run reads.
  • scripts/tests/test_review_pr.sh — the folder step in the brief, and each
    create_artifact and update_artifact call asserted with all of its fields.
  • scripts/harness/claude-code/denied-tools.txt — list_artifact_folders and
    create_artifact_folder leave the Claude Code deny list, so the folder step
    runs on that harness. update_artifact_folder and delete_artifact_folder
    stay denied.
  • VERSION 14.9.0 and its CHANGELOG.md entry. No configuration key, no
    schedule, no connection, no state format, no review verdict change.

Issue

No issue tracks this change. The operator asked for it in the direct session.

Testing

  • bash -n scripts/review-pr.sh — no syntax error.
  • bash scripts/tests/run.sh scripts/tests/test_review_pr.sh — ALL TESTS
    PASSED, about 11 minutes on the pod; the two new assertions pass.
  • check-definition.sh --base origin/main — 0 fail, 0 warn, 0 note.
  • No live run: the change is prose the model executes plus two test assertions.

A pod note, not part of this change: on a pod whose PATH starts with the
mise shims, review-pr.sh resolves gh to the real binary before the test
stub, so every prepare case fails with PR state unreadable (API). Run the
suite with PATH that holds the stub and no shim.

… artifacts (14.9.0)

The operator asked for the review pages in one artifact folder. The publish
step now resolves the folder named `PR review artifacts` (creating it when it
is absent) and passes its id, so a first guide is created inside it and every
later round's update keeps or moves it there. A failing folder call publishes
the guide ungrouped and never fails the run.

@dam-code-protector dam-code-protector Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Code Guardian - Code guardian repo — ⚠️ Code Review @ accf73a

PR #301: feat: every review guide publishes into one artifact folder (14.9.0)

Author: dam-code-protector[bot] | Branch: feat/review-guide-artifact-folder → main | Changes: +25 −10 (5 files)

Summary

The PR makes every review guide publish into one owner folder, PR review artifacts. It states the folder steps in docs/artifact.md and in the brief that scripts/review-pr.sh prints. Limits: 2 skill(s) did not run: typescript-engineering, react-ui-engineering. 2 suggestion(s) dropped under the 🟢 budget.

Findings

  • 🟡 Warning: The folder tools stay on the Claude Code deny list, so no guide reaches the folder there. docs/artifact.md:84 and scripts/review-pr.sh:2181 now call list_artifact_folders and create_artifact_folder. scripts/harness/claude-code/denied-tools.txt:17,20 removes both tools from every Claude Code session. The folder step therefore always fails there. The fallback then publishes every guide ungrouped, and the PR's stated outcome never happens on that harness. The same contradiction fails scripts/tests/test_install_hook.sh (trim_unused_only). scripts/tests/run.sh runs that file in CI, so this PR makes CI red. Reported by Agent Engineering, Issue Fit.
    Fix: Remove the create_artifact_folder and list_artifact_folders lines from scripts/harness/claude-code/denied-tools.txt in this PR, and run scripts/tests/test_install_hook.sh until it passes.

  • 🟡 Warning: The new create line has no test that fails when folder_id is removed. The assertion at scripts/tests/test_review_pr.sh:2495 matches only the prefix create_artifact {title: "PR #1 review guide". A later removal of the new field keeps the suite green. New guides would then publish outside the folder again, and no test would report it. The update branch does carry such an assertion, at scripts/tests/test_review_pr.sh:2579.
    Fix: Assert the whole create line, folder_id: "<id>" included, so that its removal fails the suite.

Issue Fit

No linked issue — scope checked against the PR description only. The PR body says that the operator asked for the change in the direct session.

✅ No findings.

Human Review Guide

📊 Visual guide for the human reviewer — Judge the folder name, the ungrouped fallback, and the steps stated twice (about 8 min)

Documentation Check (doc-drift)

✅ No findings.

Agent Engineering

✅ No findings.

Verdict

COMMENT — Two findings ask for the harness deny list and the create-line test before merge.


Review by Code Guardian - Code guardian repo · automated code guardian · cb/rits/deepseek-ai/DeepSeek-V4.1-Flash-1017 on pi

…ef calls asserted whole

list_artifact_folders and create_artifact_folder leave denied-tools.txt, so the
review guide reaches its folder on Claude Code and test_install_hook.sh passes.
Each create_artifact and update_artifact assertion of a brief case matches the
whole call, folder_id included.
@xjacka

xjacka commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Answer to the review at accf73a, fixed in 2ca095c:

  • Fixed — folder tools denied on Claude Code: list_artifact_folders and create_artifact_folder are removed from scripts/harness/claude-code/denied-tools.txt, and its section comment now says that the review guide lists and creates its folder. update_artifact_folder and delete_artifact_folder stay denied. docs/artifact.md:84 and scripts/review-pr.sh:2181 stay as they are: the calls are correct, the deny list was the defect. The CHANGELOG.md 14.9.0 entry now says that the migration refreshes the harness deny list.
  • Fixed — create line without a failing test: scripts/tests/test_review_pr.sh:2495 asserts the whole create_artifact call, folder_id included. The same sweep makes the update assertions at lines 2579, 2785 and 2806 match the whole update_artifact call, folder_id included.

Checks: the create_artifact_folder|list_artifact_folders grep has no hit in denied-tools.txt; each brief call is asserted with all of its fields. test_install_hook.sh and test_review_pr.sh (Docker, ubuntu:26.04): ALL TESTS PASSED. check-definition.sh --base origin/main: 0 fail, 0 warn, 0 note. The PR body declares the deny-list change under Scope and Gates you changed.

@xjacka xjacka added the code-guardian:rereview Request a code-guardian delta re-review label Nov 6, 2026

@dam-code-protector dam-code-protector Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Code Guardian - Code guardian repo — ✅ Code Review @ 2ca095c

Verdict: APPROVE. This account opened the pull request. GitHub does not let it approve or request changes, so this review is a comment.

PR #301: feat: every review guide publishes into one artifact folder (14.9.0)

Author: dam-code-protector[bot] | Branch: feat/review-guide-artifact-folder → main | Changes: +31 −16 (6 files)

Summary

Every review guide now publishes into one artifact folder named PR review artifacts. An update moves a guide that was published outside it.
Limits: 2 skill(s) did not run: typescript-engineering, react-ui-engineering.

Changes since last review

Previous HEAD: accf73a (2026-11-06T20:25:57Z) — verdict COMMENT

  • ✅ Fixed: folder tools denied on Claude Code; guard test fails (docs/artifact.md:84)
  • ✅ Fixed: create line loses folder_id without a failing test (scripts/tests/test_review_pr.sh:2495)

Findings

No new findings at this HEAD.

Issue Fit

No linked issue — scope checked against the PR description only.

✅ No findings.

Human Review Guide

📊 Visual guide for the human reviewer — at accf73a: the fixes change no decision the person must judge

Documentation Check (doc-drift)

✅ No findings.

Agent Engineering

✅ No findings.

Verdict

APPROVE — Both warnings are fixed, the guard test passes, and the doc matches the brief.


Review by Code Guardian - Code guardian repo · automated code guardian · cb/rits/deepseek-ai/DeepSeek-V4.1-Flash-1017 on pi

@dam-code-protector dam-code-protector Bot removed the code-guardian:rereview Request a code-guardian delta re-review label Nov 6, 2026
@xjacka
xjacka merged commit 2a9141a into main Nov 7, 2026
3 checks passed
@xjacka
xjacka deleted the feat/review-guide-artifact-folder branch November 7, 2026 11:00
xjacka added a commit that referenced this pull request Nov 7, 2026
…try and VERSION become 14.10.0

Main's 14.9.0 entry stays byte for byte. The card is a new feature with
purely additive adoption, so the next version is minor
(docs/self-modification.md §12).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants