Wait for focus to return in the project dialog tests - #828
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests in
ProjectsPage.test.tsxasserteddocument.activeElementimmediately after the dialog left the DOM.ProjectDialogreturns focus to its opener in an effect cleanup, and React runs that cleanup after it removes the dialog. The assertion could run while focus was still on<body>, and the test then failed.Both assertions now wait for focus:
renames from the project actions and retains the draft on failurereturns focus to the project actions when the opener unmountsNo product code changes.