Remove SandboxSettings - #826
Merged
Merged
Conversation
czpython
force-pushed
the
drop-sandbox-service-token
branch
from
October 4, 2026 15:20
1cf4481 to
02bb455
Compare
czpython
changed the title
czpython
force-pushed
the
drop-sandbox-service-token
branch
from
October 4, 2026 15:38
02bb455 to
64acf4e
Compare
czpython
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SandboxSettingscopied values fromSettingsinto every harness, but the harnesses read onlyharness_config_rootandskills_dir. The Claude and Codex harnesses now read those two fromload_settings()when they build the files for the box, andSandboxSettingsis removed.This also removes two paths that only tests reach:
Settings.skills_diralways returns a path.