Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rsFIRO to the default Ethereum token catalog and enables Ethereum wallets in Campfire. Uses the official Ethereum contract and 8 decimals, with a bundled rsFIRO SVG displayed in asset selection, token editing, wallet views, and the send screen.
Fork CI now uses the existing
scripts/prebuild.shAPI-key placeholders instead of an outdated duplicate in the workflow. This resolves the missing LetsExchange and CypherGoat constants that prevented the full suite from compiling.Addresses the configuration and token-list preservation feedback on #1444, without introducing app-name checks.
Validation:
e5331a95a: 476 tests passed, 4 skipped; all workflow steps succeeded.