Conversation
Archive empty wallet test shells without changing their contents. Their unused mock imports pull native wallet dependencies into coverage collection despite executing no assertions, triggering Linux test-process crashes. Keep all active tests and coverage enabled, add expanded logs, and bound the test step to 20 minutes and the job to 30 minutes.
Coverage collection also crashes active test processes and reproduces with serial execution. Restore all original test files and run every test without coverage instrumentation. Suspend the corresponding upload until getSourceReport can collect coverage reliably; retain bounded execution and expanded test logs.
Use canonical package URIs in the FIRO and Rosen tests. Relative imports across lib can give the same library both file and package identities in Flutter's shared incremental compiler, leaving orphan scripts that crash getSourceReport during coverage collection (dart-lang/sdk#49968). Restore coverage collection and upload while retaining the CI timeouts and all existing tests.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1445 +/- ##
===========================================
+ Coverage 4.80% 5.43% +0.63%
===========================================
Files 1110 1117 +7
Lines 111087 112079 +992
===========================================
+ Hits 5333 6091 +758
- Misses 105754 105988 +234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
this needs to be redone as it was based on a bad base. See close reason for #1444 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Rosen Bridge to the existing Swap flow for native FIRO ↔ rsFIRO on Ethereum mainnet. Users can create, fund, refresh, and resume swaps through the existing mobile/desktop confirmation screens and trade history.
Includes the rsFIRO and Campfire commits from #1444. Campfire can add FIRO, ETH, rsFIRO, USDC, and USDT wallets. The bridge and Add wallet share one rsFIRO contract definition.
Implementation
Exchange, trade persistence, wallet signing/broadcast, FIRO coin selection, and ERC-20 transaction history. Uses existing coinlib address/hex helpers and web3dart ABI encoding.lib/boundary to prevent duplicate library identities that trigger the Dart coverage collector crash. No test assertions, discovery rules, or coverage exclusions were changed; test execution is capped at 20 minutes and the job at 30 minutes.Protocol configuration and pinned upstream references are documented in
docs/rosen_bridge.md.Validation
git diff --checkpass.The full local macOS run with coverage completed without process crashes (361 passed, 4 skipped); its existing PIN test expects zero biometric calls on Linux and fails that assertion on macOS. No test assertions were changed for this CI fix.
This remains a draft until the application flows and live transfers in both directions are validated; no funds were sent during testing.