Find an instrument's names by its class in getAllNamesForInstrument - #2056
Merged
Merged
Conversation
getAllNamesForInstrument looked the instrument's display name up among
the class names the language tables map to, so it only found names where
the two are spelled alike -- Flute -- and none for an acoustic bass, whose
class is AcousticBass, or for a violin renamed for its part:
>>> instrument.getAllNamesForInstrument(instrument.AcousticBass(), 'english')
{'english': []}
It now uses the nearest class in the instrument's hierarchy that the
tables name, which also covers a subclass of one of music21's classes.
A generic Instrument, whose class the tables do not name, is still
looked up by its name.
|
coverage: 93.368% (+0.002%) from 93.366% — float3:instrument-names-by-class into cuthbertLab:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAllNamesForInstrumentlooked the instrument'sinstrumentNameup among the class names the language tables map to, so it found names only where the two are spelled alike:It now uses the nearest class in the instrument's MRO that the tables name, which also covers a renamed instrument (
Violin I) and a subclass. A genericInstrumentis still found by its name.AI-assisted (Claude).