Conversation
realizeAscending and realizeDescending cached a realization under the
node, reference and range alone. A realization asked for with
alteredDegrees and one asked for without them shared an entry, so
whichever came first answered for both. nextPitch realizes without the
alterations, and a harmonic minor scale lost its raised seventh after
one call:
>>> sc = scale.HarmonicMinorScale('g4')
>>> sc.nextPitch('a4')
<music21.pitch.Pitch B-4>
>>> sc.pitches[6]
<music21.pitch.Pitch F5>
The key now carries each alteration's degree, direction and interval.
|
coverage: 93.366%. remained the same — float3:realize-cache-altered-degrees into cuthbertLab:master |
Member
|
I think this moves me over the line to the position that it's time to get rid of alteredPitches -- i've never found them useful and they've only ever caused problems like this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realizeAscendingandrealizeDescendingcached under the node, reference and range alone, so a realization withalteredDegreesand one without shared an entry.nextPitchrealizes without them, and a harmonic minor then lost its raised seventh:AI-assisted (Claude).