Repository navigation
Include mode in pitchFromDegree cache key (fixes #1535) - #2051
Merged
mscuthbert merged 1 commit intoOct 1, 2026
Merged
Conversation
Member
|
Thanks! Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1535
Add
self.modeattribute to theAbstractScalebase class and store the raw mode onAbstractOctatonicScaleandAbstractDiatonicScaleat the end ofbuildNetworkto keep mode and pitch network consistent.Add
modederived from the abstract scale to the_PitchDegreeCacheKeyto ensure scales that share the same type and tonic but different modes no longer share cache entries. Since the key is a tuple and some modes are lists (and can't be dict keys), they are converted withstr(mode).Three regression tests in
test_scale_main.pycovering two octatonic modes, two diatonic modes, and swapping.abstractNotes for maintainers
.abstract.modemanually without callingbuildNetworkisn't supported, related to Changing a key's mode attribute is ignored by key.romanNumeral() #1478.