Skip to content

Added tests for query predicates - #3349

Merged
AndreasArvidsson merged 2 commits into
mainfrom
predicateTests
Sep 9, 2026
Merged

Added tests for query predicates#3349
AndreasArvidsson merged 2 commits into
mainfrom
predicateTests

Conversation

@AndreasArvidsson

Copy link
Copy Markdown
Member

No description provided.

@AndreasArvidsson
AndreasArvidsson requested a review from a team as a code owner September 9, 2026 16:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T17:04:22.289185Z ec3b69e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the lines/200-499 Pull request changes 200 to 499 lines label Sep 9, 2026
@AndreasArvidsson
AndreasArvidsson merged commit c6dc9b3 into main Sep 9, 2026
17 checks passed
@AndreasArvidsson
AndreasArvidsson deleted the predicateTests branch September 9, 2026 17:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec3b69e119

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +413 to +414
const operands: PredicateStep[] = validArguments[operator.name].map((arg) =>
typeof arg === "string" ? { type: "string", value: arg } : arg,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Format the predicate operands mapping

Running the repository-required pnpm run lint on this commit fails in lint:fmt, with oxfmt --check identifying this mapping as incorrectly formatted. Apply the formatter’s expected callback layout so the commit can pass the mandatory lint check.

AGENTS.md reference: AGENTS.md:L17-L20

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lines/200-499 Pull request changes 200 to 499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant