Conversation
…code/tests for PHPUnit compatibility.
- packaged/helpers ^1.17.1: Path::system/url/windows/custom first ship together in 1.17.1, so earlier 1.x releases would fail at runtime. - CubexTest\ moves to autoload-dev so consumers don't autoload the framework's test namespace. - actions/checkout moves to its latest major, v7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical CI and path-helper dependency compatibility issues remain, along with incomplete PHPUnit exception-message assertions.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Migrates the project to GitHub Actions and updates PHPUnit, PHP, and path-helper compatibility.
Changes:
- Updates PHPUnit assertions and configuration.
- Modernizes path-helper usage and dependency requirements.
- Replaces CircleCI with GitHub Actions coverage checks.
| File | Summary |
|---|---|
tests/Cubex/View/ViewModelTest.php |
Updates PHPUnit assertions and path expectations. |
tests/Cubex/View/TemplatedViewModelTest.php |
Updates string assertions. |
tests/Cubex/View/MustacheViewTest.php |
Updates string assertions. |
tests/Cubex/View/LayoutTest.php |
Updates string assertions. |
tests/Cubex/View/LayoutControllerTest.php |
Updates string assertions. |
tests/Cubex/View/BrandedTemplateViewTest.php |
Updates string assertions. |
tests/Cubex/Kernel/SubdomainKernelTest.php |
Updates string assertions. |
tests/Cubex/Kernel/ProjectKernelTest.php |
Updates array assertions. |
tests/Cubex/Kernel/EndpointKernelTest.php |
Updates string assertions. |
tests/Cubex/Kernel/CubexKernelTest.php |
Updates assertions. |
tests/Cubex/Kernel/ControllerKernelTest.php |
Updates array assertions. |
tests/Cubex/Kernel/ApplicationKernelTest.php |
Updates array assertions. |
tests/Cubex/Http/ResponseTest.php |
Updates assertions and exception expectations. |
tests/Cubex/CubexTest.php |
Updates string assertions. |
tests/Cubex/Console/ConsoleTest.php |
Updates string assertions. |
tests/Cubex/Console/ConsoleCommandTest.php |
Updates string assertions. |
tests/Cubex/Console/Commands/BuiltInWebServerTest.php |
Updates string assertions. |
src/View/ViewModel.php |
Uses updated path-helper methods. |
src/Testing/CubexTestCase.php |
Updates string assertions. |
src/Routing/Router.php |
Uses the URL path helper. |
src/Kernel/CubexKernel.php |
Uses updated path-helper methods. |
src/Cubex.php |
Uses the system path helper. |
phpunit.xml |
Updates PHPUnit configuration. |
composer.json |
Updates PHP, PHPUnit, helper, and autoload requirements. |
.github/workflows/phpunit.yml |
Adds the GitHub Actions test workflow. |
.circleci/config.yml |
Removes CircleCI configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PHPUnit 9's expectException() takes only the class, so the 25 calls passing a message (and two passing a code) had stopped checking either. They now use expectExceptionMessage() and expectExceptionCode(). .travis.yml still targeted PHP 7.0/7.1, which can't install a ~7.4 package; GitHub Actions replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Composer only reads config from the root package, so the override never reached consumers, but it disabled advisory blocking for every install of this repo. It is now just the CI install step's --no-blocking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove CircleCI configuration, migrate to GitHub Actions, and update code/tests for PHPUnit compatibility.