Repository navigation
Warn when the configured soundpack cannot be loaded (#7) - #109
Merged
Merged
Conversation
A pack that exists but fails to load (absolute mapping path, bad JSON) fell back to a directory search that finds nothing, and the reason was logged only at debug level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tahodev
pushed a commit
to tahodev/claudio
that referenced
this pull request
Oct 20, 2026
soundpacks.md said the supported audio formats were WAV and MP3; the audio decoder registry at internal/audio/registry.go registers WAV, MP3, AND AIFF (see NewDefaultRegistry). Update both the JSON validation note and the Supported Formats section. installation.md said install writes hooks for three events (PreToolUse, PostToolUse, UserPromptSubmit). Claude registry at internal/install/hook_registry.go has 14 default-enabled events. Enumerate the full list, and switch the example JSON from string form to the canonical array form Claude actually writes. Findings ctoth#109, ctoth#113, table rows for installation.md:113-119, soundpacks.md:82-83,521-523.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7.
The named-JSON-pack lookup in #7 already works on master. A pack that exists but fails to load is still silent, though, such as a JSON mapping with an absolute path (
absolute paths not allowed). The failure was logged only at debug level, then claudio fell back to a directory search that finds nothing.This raises that log line to WARN, so the reason shows in the default log.
🤖 Generated with Claude Code