Skip to content

Fix hex number primitive constructor - #16

Merged
Fryuni merged 1 commit into
masterfrom
fix-primitive-of-hex
Oct 14, 2026
Merged

Fryuni merged 1 commit into
masterfrom
fix-primitive-of-hex

Conversation

@Fryuni

@Fryuni Fryuni commented Oct 14, 2026

Copy link
Copy Markdown
Member

Summary

Parsing a hex literal correctly sets the token as the exact string of the hex literal.
But the JsonPrimitiveNode.ofHex constructor created an invalid number token containing a string token value.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@Fryuni Fryuni added the bug Something isn't working label Oct 14, 2026
@Fryuni Fryuni self-assigned this Oct 14, 2026
@Fryuni
Fryuni requested a review from renan628 October 14, 2026 13:47
@github-actions

Copy link
Copy Markdown

👋 @Fryuni
Thanks for your contribution!
The approval and merge process is almost fully automated 🧙
Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.
Happy coding! 🎉

@Fryuni
Fryuni requested a review from denis-rossati October 14, 2026 13:47
@Fryuni
Fryuni merged commit fd17dce into master Oct 14, 2026
8 of 9 checks passed
@Fryuni
Fryuni deleted the fix-primitive-of-hex branch October 14, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonPrimitiveNode.ofHex puts hex representation as string, not as a number

1 participant