Skip to content

perf(nix): reuse musl artifacts and remove redundant release checks - #322

Merged
davidabram merged 1 commit into
cool-stufffrom
perf/ci-stack-8-release-validation
Oct 11, 2026
Merged

davidabram merged 1 commit into
cool-stufffrom
perf/ci-stack-8-release-validation

Conversation

@davidabram

Copy link
Copy Markdown
Member

Summary

  • Pass prebuilt musl artifacts to Crane through its expected cargoArtifacts argument. The old inherit cargoArtifactsMusl was ignored, causing Crane to create another dependency derivation on Linux.
  • Use cargoWithProfile build --locked in the native and musl release dependency derivations, skipping the redundant cargo check --release pass. Test and Clippy derivations stay unchanged.

Motivation / baseline

Validation

  • nix flake check --fallback --print-build-logs on Linux/macOS
  • nix build .#ci-checks --fallback --print-build-logs on Linux/macOS
  • Linux musl release portability audit passes
  • Both release binaries still embed the correct commit and run sce --help / sce version as currently covered by CI
  • Linux release logs no longer build the implicit second sce-deps derivation; compare elapsed times

Scope: flake.nix only. No changes to release targets, checks, or toolchain.

@davidabram
davidabram added this pull request to stack #320 October 11, 2026 02:10
@davidabram
davidabram marked this pull request as ready for review October 11, 2026 02:35
@davidabram
davidabram merged commit a7e5dae into remove-tokio-db-runtimes Oct 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant