Repository navigation
ci(nix): reuse macOS release build for CLI smoke validation - #310
Merged
davidabram merged 1 commit intoOct 11, 2026
Merged
davidabram merged 1 commit into
davidabram merged 1 commit into
Conversation
This was referenced Oct 9, 2026
davidabram
added this pull request to stack #313
October 10, 2026 10:19
davidabram
marked this pull request as ready for review
October 10, 2026 14:15
davidabram
force-pushed
the
perf/ci-stack-2-macos-smoke-reuse
branch
from
October 10, 2026 14:24
2c2fbdf to
80c1499
Compare
davidabram
removed this pull request from stack #313
October 10, 2026 14:25
davidabram
added this pull request to stack #312
October 10, 2026 14:27
davidabram
removed this pull request from stack #312
October 10, 2026 22:50
davidabram
added this pull request to stack #320
October 10, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request stack
You are reviewing step 3/4: #310. Parent: #309. Next: #311.
MacOS currently compiles a native release-profile dependency set again after the test-profile
nix flake check(9m05 in #308), despite a parallel release validation job already building the same Darwin release-profile dependencies. Run the macOS CLI--helpandversionsmoke checks on the binary produced by.#ci-checksin release validation, and skip the redundant native.#scebuild in the macOS Nix CI job. Keep the Linux native smoke build unchanged (Linux release validation uses musl, not the native package).Trade-off: macOS smoke tests the commit-bearing release build rather than the commit-independent developer package. The native development build remains manually buildable. Keep this draft until both macOS and Linux Nix CI pass and total job timing is measured.