Skip to content

fix(init): forward HTTPS in generated devcontainers - #911

Merged
ponces merged 1 commit into
developmentfrom
fix/devcontainer-forward-https
Nov 17, 2026
Merged

ponces merged 1 commit into
developmentfrom
fix/devcontainer-forward-https

Conversation

@ponces

@ponces ponces commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

What was done

Generated devcontainers forwarded HTTP (80) and SQL Server (1433), but not HTTPS (443). With a Docker-in-Docker local MES stack, the browser could reach http://localhost/GenAI/ and then fail with ERR_CONNECTION_REFUSED when OpenID redirected to https://localhost/SecurityPortal/....

The failure was traced to the missing editor port forward: HTTPS discovery returned 200 inside the devcontainer and Traefik already published 443:8443, but the browser host had no listener on 443.

  • Add 443 to the init devcontainer template, preserving both existing forwarded ports.
  • Update generation regression assertions for customization/App initialization and supported MES versions.
  • Document HTTPS forwarding and the manual migration for existing generated projects (add 443 and reopen the devcontainer, or forward remote 443 to local 443 in the editor).

No issuer, LibreChat, certificate, image, dependency or version changes are included. No fork was created.

Validation checklist

  • Code validation: minimal template/test/documentation change; git diff --check passed.
  • dotnet restore completed.
  • dotnet test --configuration Release --no-restore --filter "TestCategory!=Integration" --logger trx: 869 passed, 2 skipped, no failures.
  • npm run check:nuget:min-age passed (32 unique PackageReference versions).
  • Full integration suite (not run; generation regression coverage is in the non-integration suite).
  • Main WorkItem linked (none supplied).
  • Targets development; no release/version bump requested.

@ponces
ponces marked this pull request as ready for review November 13, 2026 01:28
@ponces
ponces requested a review from a team November 13, 2026 01:28
@ponces
ponces force-pushed the fix/devcontainer-forward-https branch from 6e7f3d7 to 75fc2db Compare November 17, 2026 10:02
@github-actions

Copy link
Copy Markdown
Contributor

.NET Test Results

View full test report

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
cmf 58% 50% ➖
core 78% 61% ✔
Summary 66% (7257 / 11039) 56% (3541 / 6374) ➖

@ponces
ponces merged commit 71cbbc1 into development Nov 17, 2026
6 of 8 checks passed
@ponces
ponces deleted the fix/devcontainer-forward-https branch November 17, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants