Repository navigation
feat(validation): validate command and project configuration versions - #908
Conversation
Rockdell
left a comment
There was a problem hiding this comment.
The empty optional init overrides and bump suffixes introduce breaking changes. Please preserve those existing invocations and close the IoT npm-version validation gap before merging.
Rechecked against this head with a focused command-source harness using fake project files; the full test suite was not rerun.
|
Could we move argument parsing and version validation into the System.CommandLine definitions and pass the validated version objects to Within these version checks, please also look at reusing the existing helpers and removing checks or wrappers that become redundant. The bump overloads currently validate the same inputs twice, and upgrade can reload the same project configuration for every package. We should be able to keep one validation per entry point and one load per distinct configuration during preflight. Keep the existing public string overloads as validating adapters where needed for compatibility, along with the current optional defaults and the separate MES/NuGet/npm rules. |
9faf413 to
d4dbf1e
Compare
e0d8979 to
73299b0
Compare
73299b0 to
cb6473e
Compare
cb6473e to
afe5678
Compare
afe5678 to
8400508
Compare
.NET Test Results |
What was done
Version validation was inconsistent across CLI commands and project configuration loading. Missing or malformed versions could produce parsing errors or fail after command execution had already started.
This PR:
NuGetVersionandSemanticVersionin the changed commands, converting to text for existing downstream APIs and scaffolding arguments.init,new test,upgrade base,bump, and the IoT bump commands.BumpCommand, including mutually exclusive suffix options and validation of the resulting version..project-config.json, while keeping the existing minimum supported MES major version of 10 at CLI entry points.Validation
Validation checklist