Skip to content

Development reduntant dependencies - #889

Merged
manel27 merged 4 commits into
developmentfrom
development-reduntant-dependencies
Nov 13, 2026
Merged

manel27 merged 4 commits into
developmentfrom
development-reduntant-dependencies

Conversation

@manel27

@manel27 manel27 commented Oct 30, 2026 •

Copy link
Copy Markdown

What was done

Explicit references that were already supplied through another dependency path are removed, while keeping the underlying libraries available.

Removed reference Why it was redundant
Selenium.WebDriver / Selenium.Support The CMF PageObjects packages already supplied them transitively. We retained the ChromeDriver override.
SharpZipLib MES 10’s CMF packages supplied it transitively. The MES 11/12 business projects had no remaining dependency on it.
Duplicate CMF package references in Biz and GUI Their helper project references already brought in those packages.
Lower-level Core PageObjects packages Cmf.Core.Shell.PageObjects already depended on them.
Local Newtonsoft.Json DLL references and copies NuGet already supplied compile/runtime assets. The manual copies could overwrite the DLL selected by NuGet.
Local Http.Formatting references and copies in four projects Microsoft.AspNet.WebApi.Client already supplied the assembly. GUI.PageObjects retained its local reference/copy because MES 11 lacked that package path.

Validation checklist

Please ensure the following conditions are met in order for this PR to be merged:

  • Code validation (careful with side-effects)
  • Integration test run provided
  • Main WorkItem is linked
  • Target branch version is correct

@manel27 manel27 self-assigned this Nov 4, 2026
@manel27
manel27 marked this pull request as ready for review November 4, 2026 17:04
@manel27
manel27 requested a review from a team November 4, 2026 17:04
@manel27
manel27 force-pushed the development-reduntant-dependencies branch 4 times, most recently from b3b44b8 to 2277d30 Compare November 5, 2026 15:55
@manel27
manel27 force-pushed the development-reduntant-dependencies branch from 2277d30 to 40a5019 Compare November 13, 2026 12:49
@manel27
manel27 enabled auto-merge (rebase) November 13, 2026 12:49
@github-actions

Copy link
Copy Markdown
Contributor

.NET Test Results

View full test report

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
cmf 53% 48% ➖
core 77% 58% ✔
Summary 63% (6829 / 10891) 53% (3334 / 6286) ➖

@manel27
manel27 merged commit 07637e8 into development Nov 13, 2026
2 checks passed
@manel27
manel27 deleted the development-reduntant-dependencies branch November 13, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants