Repository navigation
feat(codereview): validate DEE references and deployment versions - #5
Open
padrinoski wants to merge 4 commits into
Open
padrinoski wants to merge 4 commits into
padrinoski wants to merge 4 commits into
Conversation
wasdfra
reviewed
Nov 10, 2026
| var symbol = model.GetSymbolInfo(node).Symbol; | ||
| var usedType = symbol as INamedTypeSymbol; | ||
| var extension = symbol as IMethodSymbol; | ||
| if (usedType?.TypeKind == TypeKind.Error || usedType?.IsAnonymousType == true || usedType?.ContainingNamespace?.IsGlobalNamespace == true) continue; |
Contributor
There was a problem hiding this comment.
UsedType is only the namespace and assembly from type symbols and reduced extension methods. An unqualified call brought into scope with using static resolves to a regular IMethodSymbol (ReducedFrom is null), so it is skipped here. That can let a missing UseReference declaration pass unnoticed. Please also inspect the containing type for non-extension member usages, or explicitly detect and validate static imports.
wasdfra
reviewed
Nov 10, 2026
| Roslyn to bind type/extension usages and reads the referenced CMF compiler's default namespace and | ||
| assembly arrays from metadata. No product assemblies or type initializers are executed. | ||
|
|
||
| - `DeeInvalidReference` (High): a declared namespace is known in the available metadata but is |
Contributor
There was a problem hiding this comment.
Testing showed as it being triggered as medium (attached file as reference)
Contributor
There was a problem hiding this comment.
This same finding is also a false positive. Sent in private message the scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DEE reference validation and package-version folder checks to
cmf-codereview. A DEE that relies on project-level imports can now report a missing deployed import; a new Process Rule or MasterData file under2.45.99is flagged when its owning Data manifest declares2.45.16.--added-files-listto validate added/renamed deployment content against its owningcmfpackage.json, while excluding historical edits and unversioned Services.tools/DeeCompilerCheckusing the actual restored Product compiler, and documentation for the minimal Bash task integration. Consuming pipeline YAML and package publication are outside this change.Validation
dotnet restore cmf-codereview.slndotnet build cmf-codereview.sln --configuration Release --no-restore: no warnings or errors.dotnet test cmf-codereview.sln --configuration Release --no-build: 319 passed.Documented limitations accepted for this scope
alsoIncluderules, custom reference paths and keyword configuration are not reproduced; host-supplied assemblies can cause false-positive missing-reference findings.The implementation and deferred follow-up work are documented in
cmf-codereview/docs/pr-validation.md.