Fix Flow key loss after MV3 service worker restart - #24
Merged
Merged
Conversation
crisng95
marked this pull request as ready for review
August 18, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
This makes the Manifest V3 background worker hydrate its persisted state on
every worker evaluation, not only after an extension install or a full Chrome
startup. The initialization is shared by lifecycle events so concurrent alarms
or startup events do not open duplicate WebSocket connections.
It also adds a small Node-based regression test for a cold worker start with a
stored Flow bearer token.
Why
MV3 service workers may be suspended and recreated while Chrome itself remains
open. In that path
onStartupandonInstalleddo not run. The previous codetherefore recreated the local-agent WebSocket while
flowKeywas still itsmodule default (
null), even though a valid token already existed inchrome.storage.local. The bridge then reported itself connected but had noFlow authentication until the Flow tab happened to make another authorized
request.
Validation
node --check extension/background.jsnode tests/extension_mv3_bootstrap.test.cjsThe regression test verifies that a cold worker start reads the stored token
before connecting, announces
flowKeyPresent: true, forwards the token to theagent, and does not duplicate initialization when lifecycle events overlap.