Repository navigation
fix: move go-github to v93 - #63
Open
QuentinBisson wants to merge 1 commit into
Open
QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
v93 makes NewClient take functional options and return an error; the client is built from WithAuthToken and WithEnterpriseURLs, whose parse error is returned as before.
QuentinBisson
force-pushed
the
upstream/go-github-v93
branch
from
November 2, 2026 09:33
cced179 to
6d678b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 80.96% 80.96%
=======================================
Files 28 28
Lines 1161 1161
=======================================
Hits 940 940
Misses 218 218
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors from the GitHub source carry go-github types (
*github.RateLimitError,*github.ErrorResponse). A program that matches them witherrors.Ashas to use the same go-github major as this module, so a program on a newer go-github can't recognise a rate-limit error fromDetectLatest.v93 makes
NewClienttake functional options and return an error.NewGitHubSourcenow builds the client withWithAuthTokenandWithEnterpriseURLs, and an invalid enterprise URL returns the same error as before. I know dependency upgrades are usually done in your own commits, so feel free to close this if you'd rather do the bump yourself.Tested with
make build testand golangci-lint v2.15.0 (0 issues).