Skip to content

fix: move go-github to v93 - #63

Open
QuentinBisson wants to merge 1 commit into
creativeprojects:mainfrom
giantswarm:upstream/go-github-v93
Open

QuentinBisson wants to merge 1 commit into
creativeprojects:mainfrom
giantswarm:upstream/go-github-v93

Conversation

@QuentinBisson

Copy link
Copy Markdown
Contributor

Errors from the GitHub source carry go-github types (*github.RateLimitError, *github.ErrorResponse). A program that matches them with errors.As has to use the same go-github major as this module, so a program on a newer go-github can't recognise a rate-limit error from DetectLatest.

v93 makes NewClient take functional options and return an error. NewGitHubSource now builds the client with WithAuthToken and WithEnterpriseURLs, and an invalid enterprise URL returns the same error as before. I know dependency upgrades are usually done in your own commits, so feel free to close this if you'd rather do the bump yourself.

Tested with make build test and golangci-lint v2.15.0 (0 issues).

v93 makes NewClient take functional options and return an error; the client is built from WithAuthToken and WithEnterpriseURLs, whose parse error is returned as before.
@QuentinBisson
QuentinBisson force-pushed the upstream/go-github-v93 branch from cced179 to 6d678b4 Compare November 2, 2026 09:33
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.96%. Comparing base (8ea35fe) to head (6d678b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files          28       28           
  Lines        1161     1161           
=======================================
  Hits          940      940           
  Misses        218      218           
  Partials        3        3           
Flag Coverage Δ
unittests 80.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant