Repository navigation
move pgp into its own package - #61
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the extraction or updated integration points; tests were not executed.
No open issues 🎉
What changed in this PR
Moves PGP validation into a dedicated pgp package, keeping OpenPGP compilation out of applications that do not use it.
Changes:
- Relocates PGP validators, errors, and tests.
- Replaces core PGP test dependencies with lightweight validation helpers.
- Updates documentation and test commands for the new package.
| File | Description |
|---|---|
| validate.go | Removes PGP implementation and updates the example. |
| validate_test.go | Removes tests relocated to pgp. |
| update_test.go | Uses the replacement validation helper. |
| README.md | Documents the new PGP API and usage. |
| pgp/validator.go | Defines PGP validation and checksum composition. |
| pgp/validator_test.go | Tests the relocated validator. |
| pgp/updater_test.go | Adds signed-checksum integration tests. |
| mockdata_test.go | Replaces PGP fixtures with hash-based helpers. |
| Makefile | Includes pgp in test targets. |
| errors.go | Removes relocated PGP errors. |
| detect_test.go | Uses the replacement validation helper. |
| .github/workflows/build.yml | Includes pgp in CI tests. |
Review effort: Balanced
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 80.96% 80.95% -0.02%
==========================================
Files 28 29 +1
Lines 1161 1160 -1
==========================================
- Hits 940 939 -1
Misses 218 218
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.