Skip to content

Fix #14829 (GUI: Platform configuration mismatch between UI selection and analysis log) #8833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danmar wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −9
Open

Fix #14829 (GUI: Platform configuration mismatch between UI selection and analysis log) #8833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
189e09a
Fix #14829 (Platform configuration mismatch between UI selection and …
danmar Sep 7, 2026
c0e9291
refactor
danmar Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions gui/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,15 @@ static QString fromNativePath(const QString& p) {
#endif
}

template<typename T = std::vector<std::string>>
static T toStdStringList(const QStringList& stringList) {
T ret;
std::transform(stringList.cbegin(), stringList.cend(), std::back_inserter(ret), [](const QString& s) {
return s.toStdString();
});
return ret;
}

MainWindow::MainWindow(TranslationHandler* th, QSettings* settings) :
mSettings(settings),
mApplications(new ApplicationList(this)),
Expand Down Expand Up @@ -584,7 +593,7 @@ void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLib, const bo
});
p.ignorePaths(v);

if (!mProjectFile->getAnalyzeAllVsConfigs()) {
if (checkSettings.platform.type == Platform::Native && !mProjectFile->getAnalyzeAllVsConfigs()) {
const Platform::Type platform = static_cast<Platform::Type>(mSettings->value(SETTINGS_CHECKED_PLATFORM, 0).toInt());
std::vector<std::string> configurations;
const QStringList configs = mProjectFile->getVsConfigurations();
Expand Down Expand Up @@ -697,10 +706,7 @@ void MainWindow::doAnalyzeFiles(const QStringList &files, const bool checkLib, c

if (!checkSettings.buildDir.empty()) {
checkSettings.loadSummaries();
std::list<std::string> sourcefiles;
std::transform(fileNames.cbegin(), fileNames.cend(), std::back_inserter(sourcefiles), [](const QString& s) {
return s.toStdString();
});
const std::list<std::string> sourcefiles = toStdStringList<std::list<std::string>>(fileNames);
AnalyzerInformation::writeFilesTxt(checkSettings.buildDir, sourcefiles, {});
}

Expand Down Expand Up @@ -1155,10 +1161,7 @@ bool MainWindow::getCppcheckSettings(Settings& settings, Suppressions& supprs)

const QString platform = mProjectFile->getPlatform();
if (platform.endsWith(".xml")) {
const std::vector<std::string> paths = {
Path::getCurrentPath(), // TODO: do we want to look in CWD?
QCoreApplication::applicationFilePath().toStdString(),
};
const std::vector<std::string> paths = toStdStringList(mProjectFile->getSearchPaths("platform"));
settings.platform.loadFromFile(paths, platform.toStdString());
} else {
for (int i = Platform::Type::Native; i <= Platform::Type::Unix64; i++) {
Expand Down
Loading