Repository navigation
Abstract over single transaction receivers - #5131
jmg-duarte wants to merge 4 commits into
Conversation
|
Claude finished @jmg-duarte's task in 4m 17s —— View job Review: Abstract over single transaction receiversNice refactor — pulling signing out of the submission transport and hiding single mempools/relays behind A couple of non-blocking notes, posted inline:
Everything else looks good. I couldn't run |
| /// Returns once the receiver accepted the tx. | ||
| async fn send(&self, tx: &SignedTx) -> anyhow::Result<()>; |
There was a problem hiding this comment.
Wouldn't this interface cause issues for block builders?
Or are you planning to create a temporary struct which knows the block range the tx should be submitted at such that you don't have to pass it here anymore?
Description
Follow up to the discussion in #5114 (comment), this PR introduces the TxReceiver trait, which "covers" the single mempools (and in the future, the single builders) as a single "transaction receiver".
Changes
How to test
Existing tests